Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline before module statement to fix nightly #946

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

lkastner
Copy link
Member

This broke nightly when JuliaLang/julia#51635 was merged.

     Testing Running tests...
ERROR: LoadError: Package GAP [c863536a-3901-11e9-33e7-d5cd0df7b904] source file /Users/runner/.julia/packages/GAP/gliHT/src/GAP.jl does not contain a module declaration.

@benlorenz and I still think that it should also work as it was before, but the module statement not on a new line was ugly.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #946 (6c78e30) into master (6ea7b02) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
+ Coverage   75.63%   75.68%   +0.04%     
==========================================
  Files          51       51              
  Lines        4166     4166              
==========================================
+ Hits         3151     3153       +2     
+ Misses       1015     1013       -2     
Files Coverage Δ
src/GAP.jl 87.38% <100.00%> (+0.90%) ⬆️

... and 1 file with indirect coverage changes

@fingolfin fingolfin merged commit b85912b into master Oct 10, 2023
14 checks passed
@fingolfin fingolfin deleted the lk/add_newline branch October 10, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants