More random inference improvements

oscar-system · Oct 15, 2024 · b9578e2 · b9578e2
1 parent 9a6ab21
commit b9578e2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/experimental/LieAlgebras/src/RootSystem.jl b/experimental/LieAlgebras/src/RootSystem.jl
@@ -1238,8 +1238,8 @@ function dominant_weights(T::Type, R::RootSystem, hw::Vector{<:IntegerUnion})
 end
 
 function dominant_weights(
- T::Type{<:Vector{<:IntegerUnion}}, R::RootSystem, hw::WeightLatticeElem
-)
+ ::Type{T}, R::RootSystem, hw::WeightLatticeElem
+) where {T<:Vector{<:IntegerUnion}}
  weights = dominant_weights(WeightLatticeElem, R, hw)
  return [T(_vec(coefficients(w))) for w in weights]
 end

diff --git a/src/GAP/iso_oscar_gap.jl b/src/GAP/iso_oscar_gap.jl
@@ -591,7 +591,7 @@ function AbstractAlgebra.map_entries(f::Map{T, GapObj}, a::MatrixElem{S}) where
  @assert base_ring(a) === domain(f)
  rows = Vector{GapObj}(undef, nrows(a))
  for i in 1:nrows(a)
- rows[i] = GapObj([f(a[i, j]) for j in 1:ncols(a)])
+ rows[i] = GapObj([f(a[i, j])::GAP.Obj for j in 1:ncols(a)])
  end
  return GAPWrap.ImmutableMatrix(codomain(f), GapObj(rows), true)
 end

diff --git a/src/GAP/wrappers.jl b/src/GAP/wrappers.jl
@@ -106,6 +106,8 @@ GAP.@wrap GeneratorsOfGroup(x::GapObj)::GapObj
 GAP.@wrap GetFusionMap(x::GapObj, y::GapObj)::GapObj
 GAP.@wrap GF(x::Any)::GapObj
 GAP.@wrap GF(x::Any, y::Any)::GapObj
+GAP.@wrap Group(x::GapObj)::GapObj
+GAP.@wrap Group(x::GapObj, y::GapObj)::GapObj
 GAP.@wrap GroupHomomorphismByFunction(x1, x2, x3)::GapObj
 GAP.@wrap GroupHomomorphismByFunction(x1, x2, x3, x4)::GapObj
 GAP.@wrap GroupHomomorphismByFunction(x1, x2, x3, x4, x5)::GapObj

diff --git a/src/Groups/matrices/MatGrp.jl b/src/Groups/matrices/MatGrp.jl
@@ -214,7 +214,7 @@ function _ring_iso(G::MatrixGroup{T}) where T
  y -> nf_to_QQBar(preimage(iso, y))
  )
  else
- G.ring_iso = iso_oscar_gap(base_ring(G))
+ G.ring_iso = iso_oscar_gap(base_ring(G))::MapFromFunc{parent_type(T), GapObj}
  end
  end
  return G.ring_iso::MapFromFunc{parent_type(T), GapObj}
@@ -251,7 +251,7 @@ function Base.getproperty(G::MatrixGroup{T}, sym::Symbol) where T
  assign_from_description(G)
  elseif isdefined(G,:gens)
  V = GapObj(gens(G); recursive=true)
- G.X = isempty(V) ? GAP.Globals.Group(V, GapObj(one(G))) : GAP.Globals.Group(V)
+ G.X = isempty(V) ? GAPWrap.Group(V, GapObj(one(G))) : GAPWrap.Group(V)
  else
  error("Cannot determine underlying GAP object")
  end