Fix Oscar.build() #2058
Merged
Fix Oscar.build() #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HereAround
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Looks good to me. @fingolfin the tests pass. Ready for review/merge?
|
Our CI does not test this, so it passing is irrelevant. I am busy with the kids now, will report the test outcomes later (or tweak the PR further) |
fingolfin
force-pushed
the
mh/PackageCompiler
branch
from
110801f
to
d2ad762
Compare
|
Works now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires Julia 1.9, which the code now enforces.
Resolves #1400
Draft because the tests on my system are still running (but I did not want to wait for them before submitting this, lest I forget about it)