Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QQBar export #2445

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Jun 2, 2023

Resolves parts of #1379.

For my convenience, this already includes the changes of #2444, and will be rebased, once that has been merged.

This PR is a draft until the scope has been discussed in #1379.

@lgoettgens lgoettgens marked this pull request as draft June 2, 2023 18:35
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #2445 (6285015) into master (4f06d82) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
- Coverage   73.08%   73.05%   -0.03%     
==========================================
  Files         397      397              
  Lines       53449    53449              
==========================================
- Hits        39061    39049      -12     
- Misses      14388    14400      +12     

see 5 files with indirect coverage changes

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase.

@fingolfin
Copy link
Member

Removing QQBar from the export list was already agreed upon in #1379, wasn't it?

In any case, can't hurt to have @fieker or @thofma have another look at this, too

@fingolfin fingolfin requested review from fieker and thofma August 24, 2023 10:40
@lgoettgens lgoettgens marked this pull request as ready for review August 24, 2023 11:37
@lgoettgens
Copy link
Member Author

This now only removes QQBar export. For the other things, the discussion will be held in #1379 and I will create a new PR afterwards.

@fingolfin fingolfin closed this Aug 29, 2023
@fingolfin fingolfin reopened this Aug 29, 2023
@fingolfin fingolfin enabled auto-merge (squash) August 29, 2023 13:43
@fingolfin fingolfin merged commit 705adb1 into oscar-system:master Aug 29, 2023
@lgoettgens lgoettgens deleted the lg/export-QQBar branch August 29, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants