Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted GroupCharacters.jl #266

Merged
merged 1 commit into from
Feb 5, 2021
Merged

adjusted GroupCharacters.jl #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions examples/GroupCharacters.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ And here are a few examples how the current code is intended.

# Examples
```
include( "GroupCharacters.jl" )

using Oscar

Oscar.example("GroupCharacters.jl")

# an ordinary character table from the GAP library
t = Main.GroupCharacters.character_table("A5");

Expand Down Expand Up @@ -136,14 +136,14 @@ using Oscar
# character values are elements from QabField
#using QabModule
#import QabModule: QabElem
include("QabAndPChars.jl")
include("../experimental/Rings/QabAndPChars.jl")

# functionality for displaying character tables
include("MatrixDisplay.jl")

import Base: getindex, length, mod, one, print, show, zero

import AbstractAlgebra: nrows, ncols
import Oscar: nrows, ncols

import Nemo: degree

Expand Down Expand Up @@ -426,8 +426,8 @@ function Base.print(io::IO, tbl::GAPGroupCharacterTable)
print(io, "character_table($id)")
end

AbstractAlgebra.nrows(tbl::GAPGroupCharacterTable) = length(GAP.Globals.Irr(tbl.GAPTable))
AbstractAlgebra.ncols(tbl::GAPGroupCharacterTable) = length(GAP.Globals.Irr(tbl.GAPTable))
Oscar.nrows(tbl::GAPGroupCharacterTable) = length(GAP.Globals.Irr(tbl.GAPTable))
Oscar.ncols(tbl::GAPGroupCharacterTable) = length(GAP.Globals.Irr(tbl.GAPTable))

function Base.getindex(tbl::GAPGroupCharacterTable, i::Int)
return group_class_function(tbl, GAP.Globals.Irr(tbl.GAPTable)[i])
Expand Down