Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stabilizer for G-sets #4206

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

ThomasBreuer
Copy link
Member

resolves #3259

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (24c8f63) to head (8d54838).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Groups/action.jl 78.57% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4206   +/-   ##
=======================================
  Coverage   84.59%   84.60%           
=======================================
  Files         631      631           
  Lines       84906    84915    +9     
=======================================
+ Hits        71830    71842   +12     
+ Misses      13076    13073    -3     
Files with missing lines Coverage Δ
src/GAP/wrappers.jl 94.94% <100.00%> (+0.03%) ⬆️
src/Groups/gsets.jl 91.57% <100.00%> (+0.22%) ⬆️
src/Groups/action.jl 97.16% <78.57%> (ø)

... and 2 files with indirect coverage changes

@ThomasBreuer
Copy link
Member Author

One test failed because it was canceled after 2 1/2 hours (test (nightly, book, ubuntu-latest).
Since this pull request introduced a new feature that cannot be used in these tests, I think that the proposed changes are not responsible for slowing down the test.

@benlorenz
Copy link
Member

One test failed because it was canceled after 2 1/2 hours (test (nightly, book, ubuntu-latest). Since this pull request introduced a new feature that cannot be used in these tests, I think that the proposed changes are not responsible for slowing down the test.

I have seen this happen in the scheduled tests on master as well: https://github.com/oscar-system/Oscar.jl/actions/runs/11285680359/job/31388879146

@joschmitt
Copy link
Member

The failing test seems unrelated because it also fails on master, so I merge this now.

@joschmitt joschmitt merged commit 8451da1 into oscar-system:master Oct 17, 2024
28 of 29 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_stabilizer branch October 17, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement stabilizer for (transitive?) G-sets
4 participants