Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add is_atlas_character_table #4416

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

ThomasBreuer
Copy link
Member

(The new function is almost trivial.
The current code looks so complicated because we want to pass the function as an argument to all_character_table_names,
and we want GAP to use its precomputed data.)

(The new function is almost trivial.
The current code looks so complicated because we want to pass the function
as an argument to `all_character_table_names`,
and we want GAP to use its precomputed data.)
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (cf2e23f) to head (506d7cd).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4416      +/-   ##
==========================================
+ Coverage   84.33%   84.34%   +0.01%     
==========================================
  Files         663      663              
  Lines       87783    87788       +5     
==========================================
+ Hits        74028    74042      +14     
+ Misses      13755    13746       -9     
Files with missing lines Coverage Δ
src/GAP/wrappers.jl 95.17% <100.00%> (+0.03%) ⬆️
src/Groups/group_characters.jl 96.39% <100.00%> (+0.73%) ⬆️
src/Groups/libraries/libraries.jl 96.15% <100.00%> (+0.07%) ⬆️

... and 11 files with indirect coverage changes

Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
@fingolfin fingolfin enabled auto-merge (squash) January 6, 2025 18:08
@fingolfin fingolfin merged commit af07ca0 into oscar-system:master Jan 6, 2025
25 of 27 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_is_atlas_table branch January 6, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants