Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No type piracy: remove matrix*vector methods for Nemo types #760

Merged
merged 3 commits into from
Oct 21, 2024
Merged

No type piracy: remove matrix*vector methods for Nemo types #760

merged 3 commits into from
Oct 21, 2024
+31 −53

Commits on Oct 21, 2024

  1. No type piracy: remove matrix*vector methods for Nemo types

    @fingolfin
    fingolfin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ecf2412 View commit details
    Browse the repository at this point in the history

  2. Adjut tests

    @fingolfin
    fingolfin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    34f1ab8 View commit details
    Browse the repository at this point in the history

  3. Remove more problematic * methods 

    Multiplying FreeModuleElem by a matrix group element returning a
Vector{} is weird and shouldn't be done. While this could be fixed
by adding a second transpose call, I don't think this kind of
inefficient operation should be encouraged, that vector space
simply is a right-module, end of story.

In a similar vein, remove the three argument * method.
    @fingolfin
    fingolfin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a011fee View commit details
    Browse the repository at this point in the history