Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenient macro for polynomial rings. #11

Merged
merged 3 commits into from
Jan 25, 2018

Conversation

wbhart
Copy link
Contributor

@wbhart wbhart commented Jan 23, 2018

No description provided.

@wbhart
Copy link
Contributor Author

wbhart commented Jan 23, 2018

This PR adds the capability to do things like:

R = @PolynomialRing(ZZ, "x", 7)
f = x1 + 3x2 + x7^2

Note that "x" and 7 have to be literal constants. They can't be variables. I don't know how to get around that limitation. It's probably possible, I just don't know how to do it.

@steenpass
Copy link
Contributor

I have tested this. The 'y' does indeed end up in the global scope. So this should be fixed first. Apart from that, nice code!

@steenpass steenpass merged commit 23100e8 into oscar-system:master Jan 25, 2018
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
Add convenient macro for polynomial rings.
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
* getting and setting the minpoly

* fix minpoly functions
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
* getting and setting the minpoly

* fix minpoly functions
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
* getting and setting the minpoly

* fix minpoly functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants