CI: test against Julia 1.6, too #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/ci-julia-1.6
branch
from
58f80d0
to
cd8d4dc
Compare
|
Did not know that |
|
@thofma yeah both are possible, but at this point the 1.6-nightly is more attractive, as doing this PR lead me to discover that JuliaLang/julia#38938 was not backported completely and hence issue JuliaLang/julia#38925 is not yet fixed in Julia 1.6.0-beta1 |
|
Should we merge this as is or wait till 1.6-nightly does not fail on MacOS anymore? |
|
I think we should just wait till the finally merge JuliaLang/julia#39160. Otherwise we'll just get tons of nonsense test failure reports which can be distracting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia 1.6 and nightly (= 1.7) have already diverged quite a bit; now that Julia 1.6 beta is available on GitHub Actions, let's test against that, too.
UPDATE: the announcement indicated this should work, but it doesn't... reported at julia-actions/setup-julia#66