Add hilbert_series
#694
Add hilbert_series
#694
Conversation
| return h; | ||
| }); | ||
| Singular.method("scHilbPolyWeighted", [](ideal I, ring r, jlcxx::ArrayRef<int> weights, ring Qt) { | ||
| intvec *w = to_intvec(weights); |
There was a problem hiding this comment.
Assumes that weights has the correct size, and that all its entries are positive (and maybe not too big?)
This is apparently checked in line 1304 below
| function hilbert_series(I::sideal{spoly{T}}, w::Vector{<:Integer}, Qt::PolyRing) where T <: Nemo.FieldElem | ||
| I.isGB || error("Not a Groebner basis") | ||
| R = base_ring(I) | ||
| length(w) == nvars(R) || error("wrong number of weights") |
There was a problem hiding this comment.
Is it useful in the error mesg to say how many weights were received, and how many were expected?
| is the Hilbert-Poincare series of $I$ for weights $(1, \dots, 1)$. | ||
| """ | ||
| function hilbert_series(I::sideal{spoly{T}}, Qt::PolyRing) where T <: Nemo.FieldElem | ||
| I.isGB || error("Not a Groebner basis") |
There was a problem hiding this comment.
If it is the caller's responsibility to ensure that GB for I is available then this should be in the doc!
Maybe consider an optional/kw arg which the user can use to permit hilbert_series to compute a GB if necessary?
|
addressed suggestions with 068c4a8 |
test/ideal/sideal-test.jl
Outdated
| @@ -686,6 +686,11 @@ end | |||
|
|
|||
| @test ngens(std_hilbert(j, h, w, complete_reduction = true)) == | |||
| ngens(std(j, complete_reduction = true)) | |||
| Qt,(t)= polynomial_ring(QQ, ["t"]) | |||
| t=gen(Qt,1) | |||
There was a problem hiding this comment.
Is the assignment t = gen(Qt,1) superfluous? I think line 698 already assigns the correct value to t, right?
There was a problem hiding this comment.
Not sure how I can actually try running this code; anyway, reading the code makes me believe that it is correct (under wholly reasonably assumptions about how Oscar-Singular interface works). I believe line 690 in sideal-test.jl is superfluous (but harmless), and for me in an interactive Oscar session the syntax in line 691 produces an error (but works when Ideal is replaced by ideal (all lowercase)).
|
Inconsistencies between Singular.jl and Oscar: Singular.jl has 7 variants of Ideal(..), but no ideal(..). |
test/ideal/sideal-test.jl
Outdated
| Qt,_= polynomial_ring(QQ, ["t"]) | ||
| t=gen(Qt,1) |
There was a problem hiding this comment.
| Qt,_= polynomial_ring(QQ, ["t"]) | |
| t=gen(Qt,1) | |
| Qt,t= polynomial_ring(QQ, ["t"]) |
hilbert_series(I, Qt::PolyRing) wih the new Hilbert function algorithm for sideal and smodule