Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero out syndrome in the support of UserGraph boundary nodes #40

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

oscarhiggott
Copy link
Owner

Fixes an issue where adding a detection event on a node marked as a boundary node in the Python API led to:

ValueError: No perfect matching could be found. This likely means that the syndrome has odd parity in the support of a connected component without a boundary.

E.g. This breaks tests in qiskit-qec: qiskit-community/qiskit-qec#276

The fix is just to zero out the syndrome in the support of these boundary nodes, since the algorithm already handles the boundary correctly without these additional detection events.

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (feed3ce) compared to base (df64928).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          299       299           
=========================================
  Hits           299       299           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oscarhiggott
Copy link
Owner Author

Fixes issue #41

@oscarhiggott oscarhiggott merged commit 9b14b29 into master Oct 29, 2022
@oscarhiggott oscarhiggott deleted the fix-syndrome-on-boundary branch October 29, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants