-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Vite 3 and latest babel-plugin-relay #424
Support Vite 3 and latest babel-plugin-relay #424
Conversation
@oscartbeaumont If it's alright for you, I would also credit myself in the README :) |
Feel free to! |
Whoops. Forgot to update the tests. I'm on it! |
@oscartbeaumont Okay tests should be fixed :) |
@oscartbeaumont Sorry for the pings, but tests need to be run again :D I think the playwright installation issue should now also be fixed |
@oscartbeaumont if you approve the workflow again, the tests should now succeed! I think it should be fine to go ahead and merge / release it. The migration path for users that are using v1 is:
New users can also use my create-relay-app project to correctly setup Relay with this plugin in their projects. |
@oscartbeaumont I've re-added the Vite 2 example and changed the code to support both Vite 2 and 3. The pipeline should now run tests against both versions. Users migrating now do not need to update their Vite version. Could you review the code and give me feedback whether we can merge it or not? Would love to get this in asap :) |
Just give me till the end of this week to review. I wanna give it a proper test given so much has changed but I have been super busy. |
Thanks for all of your work by the way! I have been meaning to give this project some love but just haven't found the time for it. |
Okay great :) |
@oscartbeaumont Just wanted to remind you to review this, since it's the end of the week. |
@oscartbeaumont bump |
@oscartbeaumont Do you think you'll get a chance to review it this weekend? |
@oscartbeaumont Sorry for being annoying, but it would be really great to get this in asap. |
I am really sorry for taking so long to review this. I know how annoying it is. Between my full-time job and being burnt out I just didn't get around to it until now. I moved to a pnpm workspace to make installation quicker and not require any linking. I have added @tobias-tengler as a GitHub contributor. When you create a GitHub release it will automatically push to npm. Would be nice to still use GH Issues/PRs to track changes before releases though. Also feel free to add me on Discord ( Edit: Before doing a GH Release you must update the version in the package.json's manually. |
I tried to use this plugin in a new Vite app and noticed that it doesn't work, due to the usage of
require.resolve
. While fixing this I also noticed that it has a dependency on a fixed version ofbabel-plugin-relay
, which is kind of cumbersome to maintain, so I:require.resolve
with just the plugin namebabel-plugin-relay
a peer dependencytransformSync
in order to supportartifactDirectory
importsfile:..
Closes #309
Closes #211