Ensure pio installs required dependencies. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new post_build.py file from f8a731c requires esptool to be in the environment, but pio doesn't appear to install this by default, and vscode/ubuntu 23.04+ run everything in python venv's meaning that even if you have it installed in your general workspace pio can't necessarily find it. This ensures that esptool is always available in the venv that pio is running in.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new post_build.py file from f8a731c requires esptool to be in the environment, but pio doesn't appear to install this by default, and vscode/ubuntu 23.04+ run everything in python venv's meaning that even if you have it installed in your general workspace pio can't necessarily find it.
This ensures that esptool is always available in the venv that pio is running in.