Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install OpenCC data via Gradle scripts #1487

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

WhiredPlanck
Copy link
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of this pull request

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck WhiredPlanck requested a review from Bambooin October 11, 2024 15:43
Copy link
Collaborator

@Bambooin Bambooin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add app/src/main/assets/shared/opencc/ to .gitignore file.

I compare the opencc data with Makefle and Gradle task and found that one new file was added in opencc asset folder.

app/src/main/assets/shared/opencc/JPVariantsRev.txt

I think is fine to add this file.

@WhiredPlanck
Copy link
Collaborator Author

Please add app/src/main/assets/shared/opencc/ to .gitignore file.

I compare the opencc data with Makefle and Gradle task and found that one new file was added in opencc asset folder.

app/src/main/assets/shared/opencc/JPVariantsRev.txt

I think is fine to add this file.

Yes, basically I just translate the CMake script from OpenCC to the Gradle script. This is one of the products we didn't add in the past.

@WhiredPlanck
Copy link
Collaborator Author

@Bambooin Done.

@WhiredPlanck WhiredPlanck merged commit deedd1e into osfans:develop Oct 12, 2024
4 checks passed
@WhiredPlanck WhiredPlanck deleted the opencc-data branch October 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants