Upgraded Kotlin to 2.0.0 #428
Conversation
| apiVersion.set(KotlinVersion.KOTLIN_1_9) | ||
| languageVersion.set(KotlinVersion.KOTLIN_1_9) | ||
| apiVersion.set(KotlinVersion.KOTLIN_2_0) | ||
| languageVersion.set(KotlinVersion.KOTLIN_2_0) | ||
|
|
||
| freeCompilerArgs.add("-Xexpect-actual-classes") |
There was a problem hiding this comment.
is this still required? -Xexpect-actual-classes
There was a problem hiding this comment.
https://kotlinlang.org/docs/multiplatform-expect-actual.html#expected-and-actual-classes
Sounds like they still require it in there, but I'll put a link to the docs for reference in the future.
|
Btw if you've got any idea about how to investigate why the |
Maybe open an issue for the kotlin team to investigate with a reproduction? |
|
Based on my consultation with the Kotlin devs, I suspected that this might have been an issue with IntelliJ, so I re-ran the build after upgrading to IntelliJ 2024.1.2, and it worked. However, reverting the repository declaration change in the code caused the build to fail in my forked version in a similar manner: https://github.com/severn-everett/kotlin-logging/actions/runs/9224844785 Yet it didn't fail in this project's Github actions: https://github.com/oshai/kotlin-logging/actions/runs/9224845625 Any thoughts? |
|
In your fork I saw a different error related to wasm. |
|
It was the same issue of "Gradle can't find a Kotlin 2 multiplatform dependency in the Gradle Plugins repository", and it's shown up in the Dependabot PR for updating to Kotlin 2 as well. However, I just re-ran the Github actions in my own fork successfully, so either it's a caching issue with Gradle or maybe some race condition. I'll ask the Kotlin devs, but this PR should be good to go now at least. |
|
According to the Kotlin devs, |
|
Thanks! |
|
Thanks! |
|
My plan is to release this as version 7. |
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `6.0.9` -> `7.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v7.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/7.0.0) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.9...7.0.0) #### What's Changed - WASM Anonymous Logging Refinement by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/424](https://togithub.com/oshai/kotlin-logging/pull/424) - Leverage tail recursion when creating message out of Throwable by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/423](https://togithub.com/oshai/kotlin-logging/pull/423) - Upgraded Kotlin to 2.0.0 by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/428](https://togithub.com/oshai/kotlin-logging/pull/428) **Full Changelog**: oshai/kotlin-logging@6.0.9...7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/StefanLobbenmeier/yt-dlp-compose). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
…#761) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `6.0.9` -> `7.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v7.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/7.0.0) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.9...7.0.0) #### What's Changed - WASM Anonymous Logging Refinement by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/424](https://togithub.com/oshai/kotlin-logging/pull/424) - Leverage tail recursion when creating message out of Throwable by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/423](https://togithub.com/oshai/kotlin-logging/pull/423) - Upgraded Kotlin to 2.0.0 by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/428](https://togithub.com/oshai/kotlin-logging/pull/428) **Full Changelog**: oshai/kotlin-logging@6.0.9...7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/pachli/pachli-android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
No description provided.