Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing hover performance #1038

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

jheijari
Copy link
Contributor

@jheijari jheijari commented Nov 7, 2019

Updating map hover to use OL 6 getFeatures function for hover hit detection.
getFeatures has better performance, but is less accurate than previously used forEachFeatureAtPixel.

@ZakarFin
Copy link
Member

ZakarFin commented Nov 7, 2019

Thanks! This was a good test but the functionality seems a bit off at least for point features with this change. Not sure if the reason is in OpenLayers since even on https://openlayers.org/en/latest/examples/hitdetect-vector.html the functionality feels "buggy" in a sense that when the cursor is not on any feature -> some feature is always "highlighted". Maybe we'll try this again on a later OL-version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants