Add support for automatically updating capabilities of WMS layers #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rseWMTSCapabilities(String) logic to calling function, did not improve readability
…UpdateCapabilitiesJob accordingly
ZakarFin
reviewed
Jan 9, 2018
| protected static boolean shouldUpdate(OskariLayer layer) { | ||
| Date lastUpdated = layer.getCapabilitiesLastUpdated(); | ||
| if (lastUpdated == null) { | ||
| LOG.debug("Should update layer:", layer.getId(), "last updated unknown and update rate is positive"); |
There was a problem hiding this comment.
Update rate isn't checked here, but I guess if last update is null we should always update. Maybe change the message a bit?
There was a problem hiding this comment.
True, the message is a bit misleading, update rate value is just known to be positive because we only requested such layers by calling layerService.findAllWithPositiveUpdateRateSec(). However since that is just known we can just remove that part from the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86 added possibility to automatically update capabilities of WMTS layers. This PR improves the work done in #86 by adding support for WMS layers. Pulling the information out of WMS Capabilities documents (for both WMS versions 1.1.1 and 1.3.0) is refactored (rewritten).
Also adds possibility to set different update frequency for each and every layer. The update rate is configured via
oskari_maplayer.capabilities_update_rate_secwhich defaults to 0 (never) making this even more of an opt-in feature.