Remove JNDI requirement #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example in Tomcat the context is read-only (by default at least) and we need to provide the JNDI context datasource from Tomcat. As we don't need JNDI anymore after migrating from Ibatis to Mybatis we could just keep references to BasicDataSource we create and NOT trying to inject them into context (as this is problematic in for example Tomcat). We already keep references to created datasources for teardown purposes.
This should enable bundling in the Postgres/JDBC driver inside the war-file and make for example Azure App Service deployments easier.