Fix email validation #939
Merged
Fix email validation #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jampukka
reviewed
Mar 24, 2023
control-users/src/main/java/fi/nls/oskari/control/users/RegistrationUtil.java
Outdated
Show resolved
Hide resolved
jampukka
reviewed
Mar 24, 2023
control-users/src/main/java/fi/nls/oskari/control/users/RegistrationUtil.java
Outdated
Show resolved
Hide resolved
Compile the regexp pattern once
|
Uhm sorry, I wanted to test the suggest changes functionality but ended up creating commits to the PR, whoopsie! |
|
No worries :) Thanks for the review :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that the email validation was broken in #924. This fixes the issue and uses regexp from https://owasp.org/www-community/OWASP_Validation_Regex_Repository for validating the address.
Note to self: add/require more unit tests...