Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change flyway/example to flyway/app #62

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

rekjuh
Copy link

@rekjuh rekjuh commented Dec 3, 2024

Change suggested long ago in Oskari-documentation/HowToModifyAppSetups.md

Change suggested long ago in Oskari-documentation/HowToModifyAppSetups.md
@ZakarFin
Copy link
Member

ZakarFin commented Dec 3, 2024

Unfortunate timing with the release just yesterday. But a good change for the next version that might be 3.0

@jampukka
Copy link
Member

jampukka commented Dec 3, 2024

Checksum comparison will cause error on second run, no?

@ZakarFin
Copy link
Member

ZakarFin commented Dec 3, 2024

Checksum comparison will cause error on second run, no?

That is true, but we have also done this in the past as this is a starting point/template for a customized app and not something that is meant to be updated from as such when updating the app: https://github.com/oskariorg/sample-server-extension/blob/master/README.md?plain=1#L53

Having the app specific migrations to be in a more generic "app" module makes sense since the developer can just tinker around with the current starting migrations instead of first renaming the package they are in (from example to something more appropriate for the customised app).

@ZakarFin
Copy link
Member

Let's change this for 3.0 just to be sure

@ZakarFin ZakarFin changed the base branch from develop to java17 January 9, 2025 11:23
@ZakarFin ZakarFin merged commit 9e00e86 into oskariorg:java17 Jan 9, 2025
2 checks passed
@ZakarFin ZakarFin added this to the 2.0.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants