Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save bridgeID #2

Merged
merged 3 commits into from
Apr 8, 2018
Merged

save bridgeID #2

merged 3 commits into from
Apr 8, 2018

Conversation

dgomes
Copy link

@dgomes dgomes commented Apr 8, 2018

keep bridgeID inside configuration.yaml

@oskarn97
Copy link
Owner

oskarn97 commented Apr 8, 2018

Thanks!
BridgeID is "bridge" by default and not the iEEE Adress because this is used in the FHEM plugins...
I know a unique ID would maybe be a better idea but the module would not work anylonger. Maybe we can make this optional?

@dgomes
default values
d0386b9 
Don’t change the configured bridgeID (backward compatible with bridgeID
= “bridge”)
@dgomes
Copy link
Author

dgomes commented Apr 8, 2018

As a compromise:

  • default configuration.yaml keeps "bridge"
  • removing the default parameter from the config file will auto save the ieee address

@oskarn97
Copy link
Owner

oskarn97 commented Apr 8, 2018

cool idea, thanks!

@oskarn97 oskarn97 merged commit e0485ce into oskarn97:master Apr 8, 2018
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Switch: support single, double, triple, quadruple and long clicks. os…
e56162d 
…karn97#2
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Support more sensor. oskarn97#2
3ee7c54
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Force documentation consistency. oskarn97#2
d6b2623
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Perfy is nice but we dont need it :(. oskarn97#2
26027bf
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Use Xiaomi model ids. oskarn97#2
a8bbd85
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Fix yaml read exception. oskarn97#2
4c6ab0e
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
More robust MQTT handling. oskarn97#2
dc21102
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Automatically generated docs. oskarn97#2
3d3a8d6
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Add npm start again. oskarn97#2
2cfd078
dgomes pushed a commit to dgomes/zigbee2mqtt that referenced this pull request May 18, 2018
@Koenkk
Support MQTT authentication. oskarn97#2
0055302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgomes @oskarn97