Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernize addon #54

Closed
2 of 6 tasks
0xadada opened this issue Apr 30, 2019 · 2 comments
Closed
2 of 6 tasks

modernize addon #54

0xadada opened this issue Apr 30, 2019 · 2 comments

Comments

@0xadada
Copy link
Contributor

0xadada commented Apr 30, 2019 •
edited by oskarrough
Loading

This addon could use some modernization luvin 💖:
0xadada added a commit to mirai-audio/ember-youtube that referenced this issue May 5, 2019
@0xadada
remove implicit dependencies on jQuery
083a355 
For apps that explicitly remove their dependency on jQuery, this addon will break because it
imports from jquery assuming the consuming app already has it.

jQuery is imported in the component, but no dependency is declared in
the package.json. This works because until recently, jQuery was
available packaged with Ember source.

[Ember RFC 0386](https://emberjs.github.io/rfcs/0386-remove-jquery.html)
propses to remove jQuery eventually, and Ember already ships with the
@ember/jquery package installed directly as part of the "ember new"
output for new ember apps.

related to oskarrough#54
@0xadada 0xadada mentioned this issue May 5, 2019
Merged
@oskarrough oskarrough mentioned this issue May 6, 2019
Open
@oskarrough oskarrough mentioned this issue Jun 10, 2019
Merged
@oskarrough
Copy link
Owner

oskarrough commented Jun 10, 2019 •
edited
Loading

@oskarrough
Copy link
Owner

Hey, I'm very sorry this never got merged. Are you still interested in it? I don't have any capacity to look at it I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xadada @oskarrough