Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing.md #13

Open
1 task done
felipepaes opened this issue Nov 20, 2023 · 3 comments
Open
1 task done

Update contributing.md #13

felipepaes opened this issue Nov 20, 2023 · 3 comments

Comments

@felipepaes
Copy link
Collaborator

Summary

The contributing.md documentation is currently outdated. There's a possibility of encountering the same error currently occurring in the CI when setting up our development environment, so this issue may be related to #1.

Documentation Page Link

https://github.com/osl-incubator/conda-forge-warning/blob/27009c6141236b6b2a3a4103733ac202f2868b24/docs/contributing.md

Code of Conduct

  • I agree to follow the Code of Conduct
@felipepaes
Copy link
Collaborator Author

felipepaes commented Nov 20, 2023

Will be documenting the steps we have used during setup:

  • There's no mentioning about the miniforge requirement
  • Add the step to use mamba when creating the environment with conda/dev.yaml environment file
  • Activate conda environment (conda activate cf-warning)
  • Install dependencies with poetry (poetry install) with conda cf-warning env active
  • copy .env.tpl as .env and add GITHUB_TOKEN= (it's a good a ideal to link github documentation on token generation)
  • run makim tests.unittest
  • if everything works, congratulations 🎉

@felipepaes
Copy link
Collaborator Author

Hey @tintayadev! 👋
Just an update on that issue from yesterday
After generating a github token, my tests have run just fine.
image

This may be related to the scope from you generated token, we may have to mention it on contributing.md as well.

Here is a reference image:
image

So maybe you can play with the scopes from your generated gh token or maybe delete your old gh token and generate a new one

@tintayadev
Copy link
Contributor

Oh I see, I'll check on that right now 😅
Thanks for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants