Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Plan for next steps #2

Open
10 tasks
xmnlab opened this issue Nov 6, 2023 · 4 comments
Open
10 tasks

EPIC: Plan for next steps #2

xmnlab opened this issue Nov 6, 2023 · 4 comments
Labels
Milestone

Comments

@jaimergp
Copy link

jaimergp commented Nov 7, 2023

Some more suggestions by @beckermr:

  • repos that have tons of downstream children have only a few maintainers
  • repos whose build times are close to 6 hours
  • repos with failed builds on main

@xmnlab
Copy link
Member Author

xmnlab commented Nov 7, 2023

@jaimergp and @beckermr thank you for your suggestions! Appreciate that!

@h-vetinari
Copy link

h-vetinari commented Nov 7, 2023

Feedstocks where the autotickbot has accummulated more than 3 open PRs

It might also make sense to differentiate between version updates and migrations. If there's no open version update PRs, that might be just because it's a package with very low release cadence, or because the bot failed (see below). Alternatively, if many failed migration PRs pile up, then the feedstock is almost always dormant/dead.

Speaking about the version bot failures, there's a section on the conda-forge status page dealing with feedstocks where the autotickbot failed to open a PR in the first place - i.e. one step before you can reasonably rely on that metric for most feedstocks.

We discussed a long time ago to make automated issues for these, but that hasn't materialized yet. If it's easier to put that information into a dashboard, that might already be a substantial improvement.

Other than that:

  • This effort probably also needs a whitelist. Things like conda-forge-{pinning,repodata-patches}-feedstock will never go out of date, and pytorch/tensorflow are under constant attention as well (only very hard to build, hence the pent up PRs).
  • It should ideally pick up feedstocks from abandoned feedstocks? conda-forge/conda-forge.github.io#1724 / Maintenance of k*-ecosystem conda-forge/conda-forge.github.io#1861, and avoid high-volume (not least due to many abi_migration_branches) feedstocks like arrow
    • for that, something like "last-non-bot-commit" or "last-non-bot-comment" would probably be helpful metrics
  • discount open PRs that are in draft mode - sometimes larger refactors on a feedstock are open for a long time, but that's not a sign of bad health
  • don't weight issues too heavily; often there are questions that are left open for reasons of visibility, or problems that aren't fixable in the foreseeable future, or a list of todos for further incremental improvements etc.
  • Some sensitivity about nomenclature. Issuing a "warning" about feedstocks with 1 open issue and one open PR is not going to be helpful IMO, especially in an age where automated tools are liable to start screaming at their users about these things (c.f. the situation with CVEs).
    • I consider it very important that this does not become a blunt hammer used against still-active maintainers, especially where it's a false positive.
    • The simplest is probably either a cut-off below which nothing is displayed, or a category below "Warning" that just lists the scraped status of these feedstocks under a more neutral heading.

@xmnlab
Copy link
Member Author

xmnlab commented Nov 8, 2023

Thanks @h-vetinari for your inputs!
I will take a time to process all the inputs here.

@xmnlab xmnlab changed the title Plan for next steps EPIC: Plan for next steps Nov 17, 2023
@xmnlab xmnlab added the epic label Nov 17, 2023
@xmnlab xmnlab added this to the OSL-C2023-01 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants