-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ssh): support SSH-based command execution #124
feat(ssh): support SSH-based command execution #124
Conversation
tests/smoke/.makim-ssh.yaml
Outdated
tasks: | ||
start: | ||
help: Start a service from the dockerfile for ssh tests | ||
dir: ../../containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dir: ../../containers | |
dir: containers |
tests/smoke/.makim-ssh.yaml
Outdated
|
||
build: | ||
help: Build the dockerfile for ssh tests | ||
dir: ../../containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dir: ../../containers | |
dir: containers |
@xmnlab, the implementation functions correctly on Ubuntu; however, it encounters an issue on macOS. The problem arises because Docker is not installed on macOS, resulting in the inability to locate the Docker command. |
thanks @abhijeetSaroha ! just skip these tests for macos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for working on that @abhijeetSaroha
appreciate that!
🎉 This PR is included in version 1.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Solves #98