-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix profile's mechanism and update OSL profile #189
Changes from all commits
c40628f
2e0b287
d5e91ba
2ca416a
80ea4c4
52ee27c
51eb650
88e7bb7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,18 +3,19 @@ name = "scicookie" | |
version = "0.6.2" # semantic-release | ||
description = "Cookiecutter template for a Python package" | ||
authors = ["Ivan Ogasawara <ivan.ogasawara@gmail.com>"] | ||
license = "BSD" | ||
license = "BSD-3-Clause" | ||
include = [ | ||
{path = "src/scicookie/cookiecutter.json"}, | ||
{path = "src/scicookie/{{cookiecutter.project_slug}}"}, | ||
{path = "src/scicookie/hooks"}, | ||
{path = "src/scicookie/profiles"}, | ||
] | ||
|
||
[tool.poetry.scripts] | ||
"scicookie" = "scicookie.__main__:app" | ||
|
||
[tool.poetry.dependencies] | ||
python = ">=3.8.1,<4" | ||
python = ">=3.8.1,<3.12" | ||
cookieninja = "1.0.0" | ||
sh = "^2.0.4" | ||
colorama = "^0.4.6" | ||
|
@@ -23,35 +24,21 @@ pyyaml = ">=6.0.1" | |
|
||
[tool.poetry.group.dev.dependencies] | ||
pytest = ">=7" | ||
black = ">=22" | ||
isort = ">=5" | ||
pre-commit = ">=3" | ||
ruff = ">=0.0.278" | ||
mypy = ">=1" | ||
ruff = ">=0.1.5" | ||
mypy = ">=1.5" | ||
pytest-cov = ">=3" | ||
pytest-cookies = ">=0.6.1" | ||
Sphinx = ">=4.4" | ||
jupyterlab = ">=3.5.1" | ||
jupyter-book = ">=0.12.3" | ||
myst-parser = ">=0.15" | ||
makim = "1.8.2" | ||
makim = "1.8.3" | ||
|
||
[build-system] | ||
requires = ["poetry-core>=1.0.0"] | ||
build-backend = "poetry.core.masonry.api" | ||
|
||
[tool.black] | ||
line-length = 79 | ||
# note: for support "py39", we need to update black using poetry | ||
# currently, it has conflicts with typing-extensions. | ||
target-version = ["py38"] | ||
force-exclude = '''(?x)( | ||
docs/* | ||
| src/scicookie/{{cookiecutter.project_slug}}/* | ||
| src/scicookie/hooks/* | ||
|.*\\.egg-info | ||
)''' # TOML's single-quoted strings do not require escaping backslashes | ||
|
||
[tool.mypy] | ||
no_strict_optional = false | ||
exclude = '''(?x)( | ||
|
@@ -76,6 +63,8 @@ exclude = [ | |
'src/scicookie/\{\{cookiecutter.project_slug\}\}', | ||
'src/scicookie/hooks', | ||
] | ||
|
||
[tool.ruff.lint] | ||
select = [ | ||
"E", # pycodestyle | ||
"F", # pyflakes | ||
|
@@ -85,11 +74,17 @@ select = [ | |
"RUF", # Ruff-specific rules | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks, I am going to change that in a bit. thanks for the update about that! |
||
"I001", # isort | ||
] | ||
fixable = ["I001"] | ||
|
||
[tool.ruff.pydocstyle] | ||
convention = "numpy" | ||
|
||
[tool.ruff.isort] | ||
# Use a single line between direct and from import | ||
lines-between-types = 1 | ||
|
||
[tool.ruff.format] | ||
quote-style = "double" | ||
|
||
[tool.pytest.ini_options] | ||
testpaths = [ | ||
"tests", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
"""SciCookie is a wrap around cookiecutter/cookieninja with a better TUI.""" | ||
"""SciCookie is a wrap around cookiecutter/cookieninja with an improved TUI.""" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ | |
"flat" | ||
], | ||
"command_line_interface": [ | ||
"No command-line interface", | ||
"None", | ||
"Click", | ||
"Argparse" | ||
], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we're not supporting Python 3.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not exactly, but we would need to test it first on CI
but the other deps we have like makim and sugar, for example, is not working with 3.12
we can add support for that in a follow-up
but I think it is better to add support for python version incrementally instead of <4, because it could silently break