-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed blue formatter from docs an .toml files #198
Conversation
@Saransh-cpp , could you please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @Vishalk91-4! See my comments below -
README.md
Outdated
@@ -20,7 +20,7 @@ for a Python package. | |||
- Licenses supported: MIT, BSD 3 Clause, ISC License, Apache Software License 2.0, and GPL 3 | |||
- Documentation engines: mkdocs, sphinx, jupyter-boook | |||
- Test library: pytest, hypothesis | |||
- Auto format code tool: blue and black | |||
- Auto format code tool: ruff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we support ruff as an auto formatter tool?
@Saransh-cpp, I have applied the mentioned changes, could you check them now |
I don't think you pushed your changes? |
I'm sorry, actually I was fixing it between my classes, so missed it |
src/scicookie/{{cookiecutter.project_slug}}/{{cookiecutter.package_slug}}/__main__.py
Outdated
Show resolved
Hide resolved
@@ -258,14 +257,6 @@ def http2ssh(url): | |||
return url.replace("/", ":", 1) | |||
|
|||
|
|||
def validation(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if this function is being called anywhere and remove all those occurences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Vishalk91-4! You can look at the failing tests locally or by clicking the details button on GitHub to see what should improved in this PR before it is ready to merge.
Please let us know if you are stuck at a test and we can try debugging that locally!
@@ -1,5 +1,3 @@ | |||
{%- if cookiecutter.use_blue -%} | |||
{%- set QUOTE = "'" -%} | |||
{%- elif cookiecutter.use_black -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, this should be if
now
@Saransh-cpp, facing this error while running tests, tried deleting template, faced another error where it couldn't find cookiecutter |
These would be issues with your local setup. It would be tough for me to reproduce them locally. Are you able to use scicookie locally to create packages? You can always see the error logs using GitHub Actions, for instance the failing |
Hi @Vishalk91-4, are you currently working on this? |
Not particularly, you can work on it now |
Pull Request description
Removed Blue formater from docs, auto-commint, pre-commit and various .toml files
Fixes #186How to test these changes
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
Additional information
Reviewer's checklist
Copy and paste this template for your review's note: