-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pixi to the template #305
Conversation
@@ -115,6 +115,8 @@ groups: | |||
maturin build | |||
{%- elif cookiecutter.build_system == "pybind11" %} | |||
python -m build | |||
{%- elif cookiecutter.build_system == "pixi" %} | |||
cargo build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My impression is that it should be pixi install
@@ -129,6 +129,8 @@ build: | |||
maturin build | |||
{%- elif cookiecutter.build_system == "pybind11" %} | |||
python -m build | |||
{%- elif cookiecutter.build_system == "pixi" %} | |||
cargo build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here, i guess that it should be pixi install ..
Not sure why it is not finding pyproject.toml .. maybe it is missing som pixi table in the pyproject.toml |
3cba1ae
to
b1c754e
Compare
@xmnlab Can you help me with this please. |
@YurelyCamacho , this is the error in the log:
that happens because pixi doesn't install the dependencies in the current environment, it creates an isolated environment for that. so you need to activate the environment first or execute it with the pixi run command:
so I would go with |
@xmnlab I used the approach you told me about in the previous comment and the same error remains. I also changed your suggestion of |
@xmnlab I can't run the tests locally because I keep getting the error I told you before about mamba, and I have it installed in the environment |
let me know if you want a quick call to check that together. about the current error on ci, the COMMAND_PREFIX is just to run the other commands with pixi run ... but you still need to install the dependencies .. so maybe with pip install should do the trick .. so you need to have both |
@xmnlab Yes, tomorrow would be good to verify that. What time can you do it? |
30fc8c2
to
93b9c2a
Compare
9eb7f20
to
50d615e
Compare
@xmnlab I think the problem is in the [tool.pixi.dependencies]. I will leave the prefix.dev answer here. Hey! The I see you added
then you should be able to do |
tests/smoke/base.sh
Outdated
else | ||
echo "Makim and Make were not found in the system." | ||
exit 1 | ||
|
||
fi | ||
|
||
python -c "import osl_python_package as mypkg; assert mypkg.__version__ == '0.1.0'" | ||
$COMMAND_PREFIX python -c "import osl_python_package as mypkg; assert mypkg.__version__ == '0.1.0'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure .. but it looks like that there is any issue running this with pixi ... so maybe you could try a different approach:
$COMMAND_PREFIX python -c "import osl_python_package as mypkg; assert mypkg.__version__ == '0.1.0'" | |
$COMMAND_PREFIX python -c 'import osl_python_package as mypkg; assert mypkg.__version__ == "0.1.0"' |
LGTM! Good job, @YurelyCamacho ! Thanks for working on that |
🎉 This PR is included in version 0.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
Edit and create files needed to add pixi to the template
Fixes #262
Pull Request checklists
This PR is a:
About this PR: