Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add new pre commits hooks #331

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

YurelyCamacho
Copy link
Collaborator

Pull Request description

Add new pre-commit hooks in project and template

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@YurelyCamacho YurelyCamacho requested a review from xmnlab December 29, 2024 22:16
@YurelyCamacho
Copy link
Collaborator Author

@xmnlab Most of the tests that fail is because of the jinja2 syntax, that's what I could see. For the project as such, none of them fail

@YurelyCamacho YurelyCamacho marked this pull request as ready for review December 30, 2024 01:59
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thabks @YurelyCamacho

@xmnlab xmnlab merged commit 72f0bf2 into osl-incubator:main Dec 30, 2024
20 checks passed
@xmnlab xmnlab mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants