Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ted module 2 #11

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Ted module 2 #11

merged 6 commits into from
Apr 30, 2024

Conversation

tedpham3
Copy link
Collaborator

@tedpham3 tedpham3 commented Apr 30, 2024

References issue #. Please review this @stephenhyang @mdtagg @sarhiri

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would cause existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

To improve code maintainability and readability by modularizing the WindowBar, Splash, Settings, and Header components.
To separate concerns within these components, making them more manageable and scalable for future development.

Approach

Broke down the WindowBar, Splash, Settings, and Header components into smaller, functional components.
Extracted reusable logic and UI elements into individual sub-components, enhancing reusability and simplification of the main component structures.
Incorporated separate SCSS files for each sub-component to maintain styling separation and clarity.
Added automated scripts in package.json, now the app would run using npm run start

Screenshot(s)

Screenshot 2024-04-30 at 3 56 40 PM

@mdtagg mdtagg merged commit 3833b31 into dev Apr 30, 2024
@mdtagg mdtagg deleted the ted-module branch April 30, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants