Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings component bug fix #13

Merged
merged 1 commit into from
May 1, 2024
Merged

Settings component bug fix #13

merged 1 commit into from
May 1, 2024

Conversation

mdtagg
Copy link
Collaborator

@mdtagg mdtagg commented May 1, 2024

References issue #. Please review this @teammember1, @teamMember2.

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would cause existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

-settings component not rendering

Approach

  • Settings component from MUI was being imported incorrectly
Screenshot 2024-04-30 at 5 23 20 PM

@mdtagg
Bug fix: Settings component
83f3be7 
Settings component was not imported correctly
Settings button from MUI was imported instead
of the local settings component
sarhiri
sarhiri reviewed May 1, 2024
View reviewed changes
Copy link

@sarhiri sarhiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work keeping track of modularized code!

@sarhiri sarhiri merged commit 16e06be into dev May 1, 2024
@mdtagg mdtagg deleted the componentsrefactor branch May 15, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarhiri sarhiri sarhiri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdtagg @sarhiri