Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John/examples #62

Merged
merged 33 commits into from
May 20, 2024
Merged

John/examples #62

merged 33 commits into from
May 20, 2024

Conversation

johnwdunn20
Copy link
Collaborator

@johnwdunn20 johnwdunn20 commented May 20, 2024

  • Added examples and created scripts to test some of them. Everything is working fin except for .js files. See DevelopmentSteps.md in package-react for details on linking process.
  • I still get weird errors in the chrome extension console that are inconsistently replicable, but not sure why/when I get them. At least one is related to the component tree and another is a bug with how I'm interacting with the chrome extension local storage. It seems like sometimes I try to set a key that already exists - this is the "duplicate block element id..." error. I suspect this could be the cause of query keys not appearing in the drop-down
  • Added better data validation in extension's App.tsx. As this is the data we control the least well, I added very basic validation to ensure it matches our types. Also updated the QueryEvents type to take in QueryKeys with elements that are int or string instead of just string. We might want to review this data hand-off in more detail
  • Added error handling and tests in react package to handle errors more gracefully. ie, if a query client isn't available, we now show a message on the console. This does not solve the .js file issues.
  • Updated versioning across extension, github readme, and react npm package
  • In the new examples, I inconsistently get this error message in the console: "index.tsx:198 Warning: You are calling ReactDOMClient.createRoot() on a container that has already been passed to createRoot() before. Instead, call root.render() on the existing root instead if you want to update it." I haven't figured this out yet

I also left a few console logs in.

@johnwdunn20 johnwdunn20 marked this pull request as ready for review May 20, 2024 05:24
Copy link
Collaborator

@austin-cavanagh austin-cavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@austin-cavanagh austin-cavanagh merged commit 03099fc into dev May 20, 2024
2 checks passed
@johnwdunn20 johnwdunn20 deleted the john/examples branch May 24, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants