Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove padding from the default shield for unknown networks #1179

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Blijbol
Copy link
Contributor

@Blijbol Blijbol commented Dec 15, 2024

This avoids wasting space (on each side, 3 pixels were reserved for the shield, but never actually used) and avoids unnecessarily small font sizes (e.g. 4-character refs are now much more readable).

This avoids wasting space (on each side, 3 pixels were reserved for the
shield, but never actually used) and avoids unnecessarily small font
sizes (e.g. 4-character refs are now much more readable).
@claysmalley claysmalley added bug Something isn't working shield-generator Issues specific to the shield library labels Dec 15, 2024
Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better. Thank you!

image

@ZeLonewolf ZeLonewolf merged commit 319154b into osm-americana:main Dec 16, 2024
6 checks passed
@Blijbol Blijbol deleted the jeroen/remove-padding branch December 19, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shield-generator Issues specific to the shield library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants