Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pier styling #336

Merged
merged 1 commit into from
May 21, 2022
Merged

Add pier styling #336

merged 1 commit into from
May 21, 2022

Conversation

claysmalley
Copy link
Member

Adds styling for piers.

before/after:

Screenshot from 2022-05-20 17-32-50 Screenshot from 2022-05-20 17-32-04

Screenshot from 2022-05-20 17-33-00 Screenshot from 2022-05-20 17-32-15

Screenshot from 2022-05-20 17-33-17 Screenshot from 2022-05-20 17-32-24

@wmisener
Copy link
Collaborator

wmisener commented May 20, 2022

Why isn't it rendering the little offshoots where the ferries launch from? E.g. https://www.openstreetmap.org/way/69707606. They seem to also have man_made=pier. Is it because they're also tagged public_transport=platform?

@claysmalley
Copy link
Member Author

claysmalley commented May 20, 2022

Those piers in particular are represented in OpenMapTiles as public transit platforms instead, which are on our roadmap but haven't been implemented yet.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for refactoring out the common background color. I agree that rendering piers with the default background color is a reasonable starting point, and we can discuss in the future whether piers should be rendered differently from the background. But rendering them as background is clearly better than not rendering them.

@claysmalley claysmalley merged commit 078755a into main May 21, 2022
@claysmalley claysmalley deleted the piers branch May 21, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants