-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow contributors to add points of interest #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should continue the discussion in #128 about whether we should minimize the number of POI icon colors, as we’ve done with roads, or have POIs occupy the full color spectrum.
I've updated this PR based on feedback received. Some screen shots: Location: (localhost link) Location: (localhost link) Location: (localhost linkl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need anything in the way of documentation? For example, the contributor’s guide could explain the POI color categories and lay out some initial criteria for POI classes at each zoom level.
@1ec5 : |
Yes, will work on adding that. |
This is looking good. I like the hospital icon, but I find the cross icon for other medical facilities looks inconsistent with it. I think changing the cross to white inside a blue round rect would unify both icons as the same general category. |
Blowing the dust off this PR. Current state: I see that @zekefarwell made a suggestion to make the cross icon consistent with the hospital "H" icon, so I'm planning to experiment with that next. |
@@ -266,7 +266,7 @@ Additionally, **`refsByWayName`** is an object mapping way names to text that ca | |||
|
|||
`refsByWayName` only works if there is no `ref` tag and the expression in the `routeConcurrency` function in layer/highway_shield.js includes the `name` property in the image name. The network needs to be listed as an input value that causes the `match` expression to append `name` to the image name. | |||
|
|||
When using `overrideByRef` or `refsByWayName`, make sure to add a line to the bottom section of this page explaining why it is necessary, as they are only intended for use in special cases. | |||
When using `overrideByRef` or `refsByWayName`, make sure to add a line to the Special Cases section of this page explaining why it is necessary, as they are only intended for use in special cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a bunch of text to the contributing guide, so this section is no longer on the "bottom"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We’ve come a long way since June. The selection of POI types is rather absurdly minimalistic, but let’s get this layer into users’ hands to give a sense of what’s possible and iterate further in separate PRs.
This PR sets up the structure for contributors to add POI icons with the following scheme:
As a demonstrar, this PR includes bars/pubs and hospitals to show how the single selector works. In addition, the source SVGs for the icons are included.
Eventually I'd like to be able to produce the PNGs from SVG at compile time so contributors can deal solely with SVGs.
The initial icons and colors are not great thanks to my limited design skills. Improvements welcome :)