Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aerialway station icon #855

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Add aerialway station icon #855

merged 4 commits into from
Apr 12, 2023

Conversation

claysmalley
Copy link
Member

Is it an enclosed gondola? Is it a chair lift? No, it's a delightfully ambiguous aerial tramway car!

Note that drag lifts also get this icon, as OpenMapTiles only differentiates aerialway subclasses on lines, not stations.

Screenshot from 2023-04-10 11-02-55
Screenshot from 2023-04-10 11-06-05
Screenshot from 2023-04-10 11-11-35
Screenshot from 2023-04-10 11-12-59

@ZeLonewolf
Copy link
Member

Is it a chairlift? Is it a gondola? The artwork is delightfully ambiguous and I think that works. Ultimately we should differentiate different types of aerialways, just like a real James Niehues map.

I would suggest one change to match the way ski area maps are typically rendered. Put the icon at the bottom of the lift line and put a round dot at the top:

image

@claysmalley
Copy link
Member Author

Put the icon at the bottom of the lift line and put a round dot at the top

I wish we could, but the necessary tag aerialway:access=* isn't surfaced in OpenMapTiles.

@ZeLonewolf
Copy link
Member

I'm seeing the icons getting rendered at the top end of chairlifts, how is it currently deciding which end to place the icon on?

@claysmalley
Copy link
Member Author

It's not deciding anything. Every aerialway=station gets an icon.

@ZeLonewolf
Copy link
Member

Ah I see, that makes sense. I was thinking the styling was on the linestring endpoints rather than the nodes themselves.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the best we can do given the limitation of what's in the tiles.

@claysmalley claysmalley merged commit 5e9885b into main Apr 12, 2023
@claysmalley claysmalley deleted the clay-poi-aerialway-station branch April 12, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants