Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add police icon #866

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Add police icon #866

merged 1 commit into from
Jun 2, 2023

Conversation

wmisener
Copy link
Collaborator

@wmisener wmisener commented Jun 1, 2023

Closes #819. Renders amenity=police (class=police, subclass=police in OMT) using an icon representing a police badge: poi_police_shield

'Infrastructure blue' and z15 as the starting zoom were chosen to match similar features like town halls. The current icon is modified based on comments in #819 to be slightly smaller (16x14 px without the halo) to better match the sizes of other icons, and the curves were accentuated to compensate. Definitely open to further modifications.

Test renderings:
Inglewood, CA (localhost link)
Screen Shot 2023-05-31 at 10 02 49 PM

Jefferson City, MO (localhost link)
Screen Shot 2023-05-31 at 10 05 35 PM

New York, NY (localhost link)
Screen Shot 2023-05-31 at 10 08 04 PM

Legend entry
Screen Shot 2023-05-31 at 10 08 30 PM

Includes taginfo and poi.js additions
@wmisener wmisener mentioned this pull request Jun 1, 2023
Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on a 2× display; someone should verify that the points on the badge are also discernible on a 1× display.

@ZeLonewolf
Copy link
Member

Looks good to me here as well:

image

@ZeLonewolf
Copy link
Member

Forced 1x looks good as well:
image

@ZeLonewolf ZeLonewolf merged commit 1bc7404 into osm-americana:main Jun 2, 2023
@wmisener wmisener deleted the wmisener/police branch June 2, 2023 05:01
@ZeLonewolf ZeLonewolf mentioned this pull request Jul 6, 2023
@wmisener wmisener mentioned this pull request Jul 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render police stations
4 participants