Flex config

[joto]

• Test more of the flex config files
• Use jsonb instead of hstore in most flex config files

[mboeringa]

@joto, while I understand the desire to add jsonb as an additional type of tag storage column, wouldn't it be better to stick with hstore as default?

hstore has been the default for quite some time, and many people may have written quite extensive SQL statements using the required syntax. Switching to jsonb might break quite a lot of existing workflows.

From a pure user perspective, there is little to gain by switching to jsonb. hstore offers most of what users likely need.

Also see the comments by Paul and Sarah here: #672

[joto]

There is only one reason to stay with hstore: "we have always done it this way". Everything else points to json: better support in PostgreSQL, builtin (no "CREATE EXTENSION" needed), "industry standard", easier to understand for new users. I believe the advantages are large enough to make this the new standard. In a few years, nobody will even remember "the old ways" of doing things. But, its only in config files, so everybody can make the choice if and when to switch as they see fit. But default configs and the documentation should point to whatever is currently considered best and recommended usw.

Also: The comments on #672 do not apply here. JSON support is already available and is easy to switch between hstore and json, there is no need for more command line options. So while it was hard to switch before, now it is easy.

[mboeringa]

Ok, reasonable arguments. Curious when all this is going to land...

[mboeringa]

@joto

As to the switch to json, this does raise one question: since json supports nested (dictionary like) structures, I wondered how the upcoming new implementation saves the tags?

I guess it is just a flat structure, because I don't see any use for a nested structure in the context of OSM objects, so I can use:

tags ->> 'seasonal'

json syntax instead of the equivalent:

tags -> 'seasonal'

for hstore?

Or do you plan to have a root level, and I do need slightly more complex syntax than this?