Implementation of ClickableWay for solitary ways (piste / dirtbike / mtb) #21714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RZR-UA
force-pushed
the
rzr-select-way
branch
2 times, most recently
from
45fe60e to
625b96f
Compare
RZR-UA
force-pushed
the
rzr-select-way
branch
from
625b96f to
9923629
Compare
RZR-UA
force-pushed
the
rzr-select-way
branch
from
a182ccd to
6c2c5de
Compare
RZR-UA
force-pushed
the
rzr-select-way
branch
from
6c2c5de to
285209c
Compare
RZR-UA
force-pushed
the
rzr-select-way
branch
from
0f21547 to
8a7cea9
Compare
RZR-UA
changed the title
Chumva
reviewed
Jan 20, 2025
OsmAnd/src/net/osmand/plus/views/layers/MapSelectionHelper.java
Outdated
Show resolved
Hide resolved
Chumva
reviewed
Jan 20, 2025
Chumva
reviewed
Jan 20, 2025
OsmAnd/src/net/osmand/plus/views/layers/MapSelectionHelper.java
Outdated
Show resolved
Hide resolved
Chumva
reviewed
Jan 20, 2025
OsmAnd/src/net/osmand/plus/views/layers/MapSelectionHelper.java
Outdated
Show resolved
Hide resolved
Chumva
reviewed
Jan 20, 2025
OsmAnd/src/net/osmand/plus/views/layers/MapSelectionHelper.java
Outdated
Show resolved
Hide resolved
Chumva
reviewed
Jan 20, 2025
OsmAnd/src/net/osmand/plus/track/clickable/ClickableWayMenuActivator.java
Outdated
Show resolved
Hide resolved
Chumva
reviewed
Jan 20, 2025
Chumva
reviewed
Jan 20, 2025
OsmAnd/src/net/osmand/plus/track/clickable/ClickableWayMenuActivator.java
Outdated
Show resolved
Hide resolved
Chumva
reviewed
Jan 20, 2025
OsmAnd/src/net/osmand/plus/track/clickable/ClickableWayHelper.java
Outdated
Show resolved
Hide resolved
ivanPyrohivskyi
approved these changes
Jan 21, 2025
Chumva
reviewed
Jan 22, 2025
Comment on lines
+136
to
+150
| if (matcher == null || matcher.publish(obj)) { | ||
| if (deletedIds.contains(obj.id)) { | ||
| // live-updates, osmand_change=delete | ||
| continue; | ||
| } | ||
| if (obj.isRoadDeleted()) { | ||
| deletedIds.add(obj.id); | ||
| continue; | ||
| } | ||
| if (usedIds.containsKey(obj.id) && usedIds.get(obj.id) != obj.region) { | ||
| // live-update, changed tags | ||
| continue; | ||
| } | ||
| loaded += (results.put(obj.getId() >> SHIFT_ID, obj) == null) ? 1 : 0; | ||
| usedIds.put(obj.id, obj.region); |
There was a problem hiding this comment.
I assume there should be an easier way to search RouteDataObjects without additional checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.