This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Support requesting object type "area" (for FlexReader) #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue mentioned in my comment has been dealt with in 534e91b. What is the suggested way to get this pull request merged? |
|
@ssiegel - happy to merge this once you rebase and add a test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demo/multipolygon/index.js doesn't work yet though: Either it needs to explicitly ask for area objects when creating the FlexReader, or FlexReader should default to osmium::osm_entity_bits::nwra instead of osmium::osm_entity_bits::nwr.
Defaulting to osmium::osm_entity_bits::nwra seems less surprising and more reasonable to me, because (at least for me) getting areas is the main reason for choosing FlexReader over BasicReader.