Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builds on travis #79

Closed
wants to merge 1 commit into from
Closed

Fix builds on travis #79

wants to merge 1 commit into from

Conversation

wiktorn
Copy link
Contributor

@wiktorn wiktorn commented Oct 27, 2018

Use pybind11 as a submodule and fix travis builds

@wiktorn wiktorn force-pushed the pybind-rewrite-travis branch from 9f0d99f to 61ca1e0 Compare October 28, 2018 20:43
@lonvia lonvia force-pushed the pybind-rewrite branch 2 times, most recently from 10e6928 to b074d8b Compare October 28, 2018 23:08
@lonvia
Copy link
Member

lonvia commented Oct 28, 2018

I've manually included this in b074d8b . I decided against including pybind as a submodule. We don't do it for libosmium either. Travis just downloads into contrib/pybind11 now, where it is found by cmake.

The gcc 4.8 issue was solvable by falling back to C++11. This should be important for #49.

@lonvia lonvia closed this Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @lonvia