Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Famxplor web map #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Famxplor web map #156

wants to merge 1 commit into from

Conversation

alt250
Copy link

@alt250 alt250 commented Sep 4, 2024

World map featuring family travel blog posts

@mtmail
Copy link
Contributor

mtmail commented Sep 4, 2024

Looking at the map requires a "login or register with google" and later "Free to try during 30 days"

@alt250
Copy link
Author

alt250 commented Sep 4, 2024

Thanks for reviewing this PR @mtmail !

Looking at the map requires a "login or register with google" and later "Free to try during 30 days"

Yes. Creating an account is free.
Sorry if this is not allowed in this list, feel free to close this PR.

Here is what the map looks like FYI:
Screenshot from 2024-09-04 16-09-05

@alt250
Copy link
Author

alt250 commented Sep 6, 2024

Another screenshot with more context (family travel activities):

image

Thanks!

Copy link
Collaborator

@Unkn0wnCat Unkn0wnCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alt250,

thanks for your contribution, however I have to agree with @mtmail. Awesome-Lists are normally meant to showcase FOSS-projects, and whilst we do have a few non-open-source tools in our lists, all of them can be used for free.

I therefore see a problem with adding Famxplor to the main list. However we may still be able to work with this by adding a secondary list. Just as we have UNMAINTAINED.md for unmaintained projects, we could have a NONFREE.md.

My suggestion is for you to remove your change to the README.md and create a NONFREE.md with the following content instead:

# Non-Free Projects

The projects listed here are cool too, but can only be used against payment and don't publish their sources. 
These commercial products are seperated from the main list to keep the main focus of the list on FOSS-projects.

## Contents

* [Maps](#maps)
  * [Web Maps](#web-maps)

## Maps

### Web Maps

* [Famxplor](https://famxplor.com/) - World map featuring travel with kids blog posts. Find activities for your family vacations worldwide.

Let me know what you think!

@alt250
Copy link
Author

alt250 commented Sep 9, 2024

Hey @Unkn0wnCat ,
Thanks for your insightful comment!

I think that adding a NONFREE.md list is a good idea. It will make the distinction between free and non-free explicit.

It just happened that in the meantime, I decided to make Famxplor free!
It is based on several free projects (like OSM) and content sources, so it makes more sense like this.

Famxplor is now free but still closed-source, so should I add it to NONFREE.md as you suggested?

@mnalis
Copy link

mnalis commented Sep 9, 2024

Famxplor is now free but still closed-source, so should I add it to NONFREE.md as you suggested?

As it is not FOSS, I think adding it to NONFREE.md would be appropriate.

@alt250 alt250 force-pushed the patch-1 branch 2 times, most recently from 039f41f to aa18851 Compare September 11, 2024 13:45
@alt250
Copy link
Author

alt250 commented Sep 11, 2024

Hey @Unkn0wnCat,
I created NONFREE.md and added Famxplor to it.
Note that I slightly modified the intro text of the non-free page.

NONFREE.md Outdated
Comment on lines 3 to 4
The projects listed here are cool too, but they can only be used against payment or do not publish their sources.
These commercial products are separated from the main list to keep the main focus on FOSS projects.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The projects listed here are cool too, but they can only be used against payment or do not publish their sources.
These commercial products are separated from the main list to keep the main focus on FOSS projects.
The projects listed here are cool too, but they require payment or do not publish their sources.
These products are separated from the main list to keep the main focus on FOSS projects.

clarify payment, also commercial products can be free (as in freedom), and non-free (proprietary) produces can be gratis (and of course products can be neither or both), so try not to conflate them incorrectly

NONFREE.md Outdated

### Web Maps

* [Famxplor](https://famxplor.com/) - Explore a world map of travel blogs with child-tested activities and family vacation ideas from around the globe.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps for each project, at the end add the short description in parenthesis why it is in this list e.g. (gratis but closed source) or whatever happens to be the case

@alt250
Copy link
Author

alt250 commented Sep 13, 2024

@mnalis Thanks for clarifying the text!
I also added "gratis, closed-source" after Famxplor as you suggested

@mtmail
Copy link
Contributor

mtmail commented Sep 13, 2024

I still think the website not OSM related enough and I don’t see it promoting OSM. Closed data is displayed on a base map behind a login, OSM attribution behind a tiny (i) on the bottom right of the map. 100.000s websites use a OSM basemap similarly. It’s one of five PRs to various awesome-* by the owner.
Of course I encourage the repo maintainers to add what they see fit.

@alt250
Copy link
Author

alt250 commented Sep 13, 2024

@mtmail Thank you for the feedback! I appreciate your perspective on the OSM relevance.

I'd like to clarify a few points:

  • The map on Famxplor features publicly available data displayed on a world map, which is powered by OSM.
  • Account creation on Famxplor is free, and the product itself is now entirely free to use.
  • The "(i)" icon in the bottom right is part of the MapLibre framework (documentation). By default, it displays attributions and auto-hides when the map is moved. I've attached a screenshot for reference:

image

While Famxplor does use OSM as its core mapping service, I understand the importance of making that more apparent. To address this, I've added a "Built with OpenStreetMap" link at the bottom of the map page. This is visible in the screenshot above.

Regarding the multiple PRs to awesome-* projects, I submitted them in the hopes of contributing to lists where I thought the project might be relevant. However, I fully respect the maintainers' decision to include what they deem appropriate.

Thank you for your understanding and encouragement!

@mnalis
Copy link

mnalis commented Sep 13, 2024

Of course I encourage the repo maintainers to add what they see fit.

While I helped trying to format this PR to be more usable if it were to be accepted, I absolutely agree that the maintainer should make a decision about where they'd want to take this project (and document it).

I.e., besides project having to be "awesome" (which is obviously highly subjective, and always subject to maintainer's final decision), should:

  1. non-FOSS projects be accepted in the list (never / always / only in very exceptional circumstances) ?
  2. walled-garden (i.e. requiring account to access) projects be accepted in the list (never / always / only those requiring OSM login / only if creating account is gratis and project is non-commercial / only if creating account is gratis (but upsell is fine) / only in very exceptional circumstances) ?
my personal preferences would be:
  1. only in very exceptional circumstances (e.g. hugely popular HDYC)
  2. only those requiring OSM login (but might accept "only if creating account is gratis and project is non-commercial" too)

@alt250
Copy link
Author

alt250 commented Sep 18, 2024

I.e., besides project having to be "awesome" (which is obviously highly subjective, and always subject to maintainer's final decision), should:

non-FOSS projects be accepted in the list (never / always / only in very exceptional circumstances) ?
walled-garden (i.e. requiring account to access) projects be accepted in the list (never / always / only those requiring OSM login / only if creating account is gratis and project is non-commercial / only if creating account is gratis (but upsell is fine) / only in very exceptional circumstances) ?

I fully understand that the submission of this project triggered these questions.
However, would discussions be a more appropriate place to discuss such matters? It may bring more visibility than this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants