Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to view tag differences of a highway #115

Closed
ramyaragupathy opened this issue Mar 22, 2017 · 8 comments
Closed

Unable to view tag differences of a highway #115

ramyaragupathy opened this issue Mar 22, 2017 · 8 comments

Comments

@ramyaragupathy
Copy link

Here is a way on OpenStreetMap, for which highway key has been changed from unclassified -> tertiary. This is part of Changeset - 46620937.

This way can be visualised on changeset-map with this link http://osmlab.github.io/changeset-map/#46620937/way/478825377.

But once deselected, way disappears. There's no way to look at this highway again. Ideally I expect a pop up with the tag difference listed.
changeset

cc @ajithranka @geohacker

@ramyaragupathy
Copy link
Author

Similar case http://osmlab.github.io/changeset-map/#47023035/node/3291970806, but here node is not highlighted at all.
OpenStreetMap history: https://www.openstreetmap.org/node/3291970806/history

@bsrinivasa
Copy link

Adding a similar case here.
http://osmlab.github.io/changeset-map/#46728124/way/5671661
The changeset map stops responding after an initial pan or zoom.

OSM Link: http://www.openstreetmap.org/way/5671661

@ajithranka
Copy link
Contributor

ajithranka commented Mar 23, 2017

Case 1

#46620937/way/478825377

  • Fetched from overpass (query)
  • Feature changed from version 16 to 18, no version 17 in the xml
  • Changeset-map fails to set a changeType in geojsonChanges.js#L54

Case 2

#47023035/node/3291970806

  • Fetched from S3 (link)
  • Node 3291970806 (history) was modified in the changeset but is not part of the json
  • Changeset-map fails when trying to select the features render.js#L104

#46728124/way/5671661

  • Fetched from S3 (link)
  • Way 5671661 (history) was modified but is not part of the json
  • Changeset-map fails when trying to select the features render.js#L104

Case 3

#39563991/way/46130066

  • Fetched from overpass (query)
  • Way 46130066 (history) was modified but version number stays at 7 in the xml
  • OSM shows the version as 8
  • Changeset-map fails to set a changeType in geojsonChanges.js#L54

cc: @batpad @geohacker

@geohacker
Copy link
Contributor

@ajithranka
Copy link
Contributor

PR #121 should fix case 1 and case 3 errors. @ramyaragupathy @bsrinivasa, please cross-check and confirm. If 👍, I'll publish to npm.

@ramyaragupathy
Copy link
Author

ramyaragupathy commented Mar 23, 2017

Looks good to me @ajithranka 🙇‍♀️

@ajithranka
Copy link
Contributor

Fixed. No next actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants