Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @osmcha/osm-adiff-parser instead of osm-adiff-parser-saxjs #268

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jake-low
Copy link
Collaborator

@jake-low jake-low commented Sep 10, 2024

We recently published a new NPM package, @osmcha/osm-adiff-parser, (source code here) which is intended to replace osm-adiff-parser and osm-adiff-parser-saxjs, neither of which are maintained anymore. The first version of @osmcha/osm-adiff-parser is v2.0.0. It is based on saxjs, so it works both in the browser and in Node, and it supports both CommonJS and ESM. It is functionally compatible with the 1.x versions of both of the other packages, though it has superficial API differences (namely, it returns a Promise rather than taking a callback function).

This PR replaces the osm-adiff-parser-saxjs in changeset-map with @osmcha/osm-adiff-parser. This has no change in observable behavior, and I've tested it to make sure that it works as expected.

See also OSMCha/osm-adiff-service#20

@tordans
Copy link
Contributor

tordans commented Sep 10, 2024

@jake-low just in case you are not aware, please have a look at https://github.com/tordans/osmcha2/tree/main/app/_components/_lib/real-changesets-parser should this part of the app come up. More context on this project is at OSMCha/osmcha-frontend#741

@willemarcel willemarcel merged commit a84d08d into master Sep 10, 2024
@willemarcel willemarcel deleted the jlow/use-new-osm-adiff-parser branch September 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants