Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect the Rhode Island imagery based on #1237 #1241

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

cicku
Copy link
Collaborator

@cicku cicku commented Aug 30, 2021

This commit:

  1. Corrects the max zoom level.
  2. Indicates that the image is not orthorectified.
  3. Specifies the imagery date.

@cicku
Copy link
Collaborator Author

cicku commented Aug 30, 2021

Is "{proj}" really needed? Or should I remove "wms"? @rbuffat

@rbuffat
Copy link
Collaborator

rbuffat commented Aug 30, 2021

@cicku It will depend on the editor, but to be sure, it would be better to add it. WMS typically requires the proj parameter, thus editors could expect the {proj} and fail if it is not available.

In the future, it would be good to distinguish between wms and the esri API.

@cicku
Copy link
Collaborator Author

cicku commented Oct 6, 2021

@andrewharvey Feel free to merge this one since they are just some minor changes.

@andrewharvey
Copy link
Collaborator

@cicku if the Fall 2020 is still available it would be best to create two sources so users can toggle between both in the editor, is the old one still available?

@cicku
Copy link
Collaborator Author

cicku commented Oct 6, 2021

The old ones are always available but because I committed the file not long before this PR, I would start doing as you said above from 2021 Spring and keep it when Fall comes out. The reason why I didn’t select 2021 imagery in #1237 is because I didn’t know iD supports reading from JSON.

The imagery has not been officially included in any version of iD and it is not even orthorectified, so there isn’t much impact.

@cicku
Copy link
Collaborator Author

cicku commented Oct 12, 2021

@rbuffat I'm not inclined to keep the old imagery in this PR. I submitted the original PR 5 days before at #1237, was expecting to fix this as soon as possible. Then, you know...

@andrewharvey
Copy link
Collaborator

I'll merge this PR because it's better to have newer imagery than older imagery, but it would be nice to have another PR which re-adds the Fall 2020 imagery as a new source. As a mapper it is useful to sometimes be able to use older imagery as well.

@andrewharvey andrewharvey merged commit bbede0e into osmlab:gh-pages Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants