Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding OSMIM as individual layers #164

Merged
merged 3 commits into from
Jun 28, 2016
Merged

Conversation

imagico
Copy link
Contributor

@imagico imagico commented Jun 27, 2016

replaces #163.

As individual layers.

Also added best flags to where it obviously fits (Northern Greenland, Alaska, Antarctic and some Subantarctic islands)

@bhousel
Copy link
Member

bhousel commented Jun 27, 2016

I did a quick test of Bing vs imagico on the Alaskan source, and I don't think imagico should be marked best here. Can you please double check all of the areas where you're making the best claim?

bing_v_imagico

@imagico
Copy link
Contributor Author

imagico commented Jun 27, 2016

I am sorry but no, since there is no comprehensive and up-to-date info on the variable quality sources like Bing which quality level is available at what location it is impossible to check this reliably within a reasonable time frame. Also it can easily change any day. I added 'best' for images where i know from looking at a representative selection of points in the image they are newest and highest quality (resolution, seasonality, cloud freeness etc.) compared to other sources i know of. This applies to the Alaska area for a huge percentage. You can of course be very picky and allow 'best' only for sources that provide best quality by all measures for 100 percent of the coverage area but for a significant portion of the sources marked as best right now there will likely be smaller parts (especially due to clouds) where this does not apply.

Ideally having several objective quality measures (like age and ground resolution) would be better than a binary measure like 'best' - see #130.

@bhousel
Copy link
Member

bhousel commented Jun 27, 2016

Please remove the best flag from any sources that you don't have time to check.

Our hope for this best flag is that local contributors can use it to mark imagery that they know to be better than Bing/Mapbox. For example, "Kanton Zürich 2015 10cm" is marked "best" because people from Switzerland say so, not because of the imagery's age and resolution. Tomorrow Bing may update their imagery and then "Kanton Zürich 2015 10cm" will no longer be the best source there, and ideally somebody from the Swiss community will notice this and open an issue to remove the flag.

@imagico
Copy link
Contributor Author

imagico commented Jun 27, 2016

OK - removed.

I only added it in the first place since @tyrasd suggested it. As previously indicated i consider the 'best' flag unsuited for what it is used for.

@bhousel
Copy link
Member

bhousel commented Jun 28, 2016

Thanks, @imagico

@bhousel bhousel merged commit 04780ba into osmlab:gh-pages Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants