Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+maxzoom Bavaria-2m #209

Closed
wants to merge 2 commits into from
Closed

+maxzoom Bavaria-2m #209

wants to merge 2 commits into from

Conversation

Klumbumbus
Copy link
Contributor

No description provided.

@simonpoole
Copy link
Contributor

Is stating a max zoom actually necessary for a WMS server? If this is a JOSM requirement we need to have a look at all WMS defs.

@Klumbumbus
Copy link
Contributor Author

Klumbumbus commented Nov 11, 2016

I don't know. With this layer and without maxzoom I see grey tiles in JOSM at z>18. While e.g. VoGIS: Echtfarbenbild 2012 (12cm) works fine in JOSM even without maxzoom.

@bhousel
Copy link
Member

bhousel commented Nov 11, 2016

Max zoom is at least useful to iD - it tells the code at which zoom to stop requesting images and switch to overzooming. (e.g. there is no reason to ask the server for 4 z19 tiles, when we know that the z18 tile we already have loaded is as good as it gets).

I know iD don't support wms yet, but even if we did, fetching raster tiles would work the same way.

@simonpoole
Copy link
Contributor

@bhousel I might be mistaken but IMHO WMS servers return which scales they support so this might simply be a misconfiguration of the WMS server in question.

@bhousel
Copy link
Member

bhousel commented Nov 11, 2016

@bhousel I might be mistaken but IMHO WMS servers return which scales they support so this might simply be a misconfiguration of the WMS server in question.

I'm thinking of the very simplest case where iD would send bounding box requests to EPSG:3857 supporting servers, per openstreetmap/iD#1141 (comment)

Specifying a maxZoom would help iD here. I'm not planning to do GetCapabilities calls anytime soon.

simon04 added a commit that referenced this pull request Nov 11, 2016
@simon04
Copy link
Contributor

simon04 commented Nov 11, 2016

Merged: 576198e

@simon04 simon04 closed this Nov 11, 2016
@Klumbumbus Klumbumbus deleted the patch-2 branch November 15, 2016 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants