-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BE_OrthoPhoto2017_Brussels_WMS.geojson #368
Conversation
Switch to TMS to be available in iD editor
Fix `{zoom}` instead of `{z}`
See #363 comments for more details about this update ! :) |
Cool @jbelien this is great!.. Do you mind if I hold of merging this for a few days? I was looking through the sources and it looks like a lot of WMS sources are already specified as supporting EPSG:3857. I think I can add a quick change on the iD side to just support these sources directly without using the proxy, then they can stay as WMS sources in the index and we don't need to change anything. (Your comment about the url path was really helpful) |
Awesome ! I do not mind at all ! :) Really happy to help ! |
Having the TMS sources is still positive for other editors and applications that don't support WMS servers and are not going to implement workarounds as @bhousel is thinking of, any time soon (for numerous reasons). Unluckily the current format of the index requires duplicating the entry for this which is not beautiful, but on the other hand really not a lot of work. PS: cooperating on a project such as this requires that decisions take in to account the requirements of all consumers (if they can always all be satisfied is a different question). Sudden changes in policy and content etc. just because one of the consumers supports a new feature, or for other reasons (which we've had in the past multiple times) is not conductive to the trust that is required to use this in a production environment. |
Any news on this merge ? :) |
Poke @bhousel |
Could this PR be merged please ? :) |
@bhousel what's the current status regarding openstreetmap/iD#1141? |
I'm really sorry for dropping the ball on this - I don't have time now to work on openstreetmap/iD#1141, so let's just merge this as-is. |
Switch to TMS to be available in iD editor