-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users with old osm editors ( Old-style OSM editor statistics: created_by | 2017 ) #27
Comments
Thanks @ImreSamu for looking at this. Potlatch2 is in the process of getting fixed to work with new style multipolygons. I don't think many people are running that outside the main osm.org page, so that is getting taken care of. It would be interesting to find out who is running old iD instances. The JOSM edits and others are probably to small to warrent any action. I would expect this to sort itself out medium term after the |
Since (openstreetmap/iD#2449)
example:
I will try to create a statistics about this. ( about: live iD Editor hosts + iD Editor versions - in 2017 ) |
Changesets>10 ( 2017.01.01 - 2017.03.22 )
full list with the long tail : https://gist.github.com/ImreSamu/fb9840c02212373552d84ac5a7bed709 |
Maybe somebody wants to talk to the people running those iD instances and encouraging them to update. But it seems these sites are mostly for editing special things and they have changes in the software for them. So a) they might not be a big problem for our purposes here and b) they probably can't just update their software easily. So unless there is some evidence of massive problems from these sites, I think we can ignore this for now. |
Are there specific problems with those old versions of iD regarding multipolgyon tagging? Or why are we talking about them here? Because, if I remember correctly, iD did always support the creation of properly tagged multipolygon relations. Legacy support for old style mps was and is still present in iD, but that shouldn't be of concern here, right? See also openstreetmap/iD#3908 (comment) Or am I overlooking or recollecting something wrongly? |
please re-check my numbers and examples .. in 2017 about a same number of old-style multipolygons created
full list: https://gist.github.com/ImreSamu/ea6f81856ceaf6e9092469490239fdf1 Search for iD - and check the relation first version. ( version="1" ) , so it is created with iD. Imho: We have at least 1722 iD Editor examples for creating old-style polygons this year ( in the history, most of them corrected now ) 5 examples:
|
@ImreSamu yes, I've read your posts. Btw: thanks for digging into this and providing the stats! What I'm asking is: Is this a bug in (current and/or old versions of) iD that has to be fixed?[*] Or is it "just" mappers manually adding old-style multipolygons (like the also substantial number of 1171 old style multipolygons that have been added by JOSM users). If it's the former, a bug report to iD should be written (a fix could potentially also be backported to patch legacy versions of iD), but if it's the latter, we should ask what the reasons for this are: Maybe the users aren't aware of the deprecation of old style MPs, or they're following out of date documentation, etc. PS: [*] I've tried to create multipolygons in iD (even in the 1.8.5 "strava slide" fork) and it works as expected: no old style multipolygons were created by using the default "merge areas" operation. The only way to actually create such an old stlye multipolygon from within iD (at least as far as I am aware of) is by manually creating an untagged multipolygon relation and manually adding the members one by one. Please correct me if I'm wrong. :) |
honestly : I don't know .. I just checking the output.
or iD editor should add an extra validation step ? for detecting polygon problems/errors ... My last example is a 5 <osm version="0.6" generator="OpenStreetMap server" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright" license="http://opendatacommons.org/licenses/odbl/1-0/">
<relation id="7086042" changeset="46983054" timestamp="2017-03-19T13:53:45Z" version="1" visible="true" user="...." uid="494937">
<member type="way" ref="481374655" role="outer"/>
<member type="way" ref="481374653" role="outer"/>
<member type="way" ref="481374656" role="outer"/>
<member type="way" ref="481374657" role="outer"/>
<member type="way" ref="481374658" role="outer"/>
<tag k="type" v="multipolygon"/>
</relation>
<relation id="7086042" changeset="47104075" timestamp="2017-03-23T18:23:43Z" version="2" visible="false" user="...." uid="665748"/>
</osm> |
Very good point! I've opened the feature request in openstreetmap/iD#3933 |
Side notes for "post monitoring" topic osmcha has an "Unknown iD instance" detection filter.
idea: maybe a new filter in osmcha for "Old-style multipolygons created" will be also useful, so we can easily monitor this info. Bonus: the "fix old-style multipolygon" changesets comments can be monitor via osmcha:
|
2017-04I have created a statistics for
And a simple statistics FREQ by changeset editor ( created_by )
$ cat old_style_created.opl| grep 2017-04-0 | cut -d' ' -f10 | sed -e 's/%20/ /' | cut -d' ' -f1 | sort | uniq -c | sort -nr
114 changeset_created_by=JOSM/1.5
102 changeset_created_by=iD
57 changeset_created_by=Potlatch
5 changeset_created_by=Vespucci
2 changeset_created_by=
1 changeset_created_by=Merkaartor
$ cat old_style_created.opl| grep 2017-04-1 | cut -d' ' -f10 | sed -e 's/%20/ /' | cut -d' ' -f1 | sort | uniq -c | sort -nr
220 changeset_created_by=JOSM/1.5
200 changeset_created_by=iD
93 changeset_created_by=Potlatch
3 changeset_created_by=Level0
1 changeset_created_by=Vespucci
$ cat old_style_created.opl| grep 2017-04-2 | cut -d' ' -f10 | sed -e 's/%20/ /' | cut -d' ' -f1 | sort | uniq -c | sort -nr
399 changeset_created_by=JOSM/1.5
267 changeset_created_by=iD
42 changeset_created_by=Potlatch
1 changeset_created_by=Vespucci
1 changeset_created_by=reverter;JOSM/1.5
1 changeset_created_by=Merkaartor JOSM versions for 2017-04-2x $cat old_style_created.opl| grep JOSM | grep 2017-04-2 | cut -d' ' -f10 | sed -e "s#%20%# #g" | cut -d' ' -f1-2 | sort | uniq -c | sort -nr
274 changeset_created_by=JOSM/1.5 (11826
74 changeset_created_by=JOSM/1.5 (11639
16 changeset_created_by=JOSM/1.5 (9979
10 changeset_created_by=JOSM/1.5 (11833
5 changeset_created_by=JOSM/1.5 (11223
5 changeset_created_by=JOSM/1.5 (10966
3 changeset_created_by=JOSM/1.5 (11427
2 changeset_created_by=JOSM/1.5 (12015
2 changeset_created_by=JOSM/1.5 (11915
2 changeset_created_by=JOSM/1.5 (11526
1 changeset_created_by=reverter;JOSM/1.5 (11826
1 changeset_created_by=JOSM/1.5 (12012
1 changeset_created_by=JOSM/1.5 (12006
1 changeset_created_by=JOSM/1.5 (11828
1 changeset_created_by=JOSM/1.5 (11514
1 changeset_created_by=JOSM/1.5 (10786
1 changeset_created_by=JOSM/1.5 (10168 TOP10 users (with manual Data anonymization for privacy -> uAnonymized1 ) ( 2017-04- ) $cat old_style_created.opl| grep JOSM | grep 2017-04 | cut -d' ' -f7 | sort | uniq -c | sort -nr | head
279 uAnonymized1
60 uAnonymized2
40 uAnonymized3
17 uAnonymized4
16 uAnonymized5
15 uAnonymized6
15 uAnonymized7
14 uAnonymized8
14 uAnonymized9
13 uAnonymized10 |
2017-06OSM history statistics for creating old-style multipolygons.
$ cat old_type201706.opl | wc -l
1195
$ cat old_type201706.opl | cut -d' ' -f 10 | sed -e "s#%20%# #g" | cut -d' ' -f 1 | sort | uniq -c | sort -nr
695 changeset_created_by=JOSM/1.5
395 changeset_created_by=iD
103 changeset_created_by=Potlatch
2 changeset_created_by=
# TOP15
$ cat old_type201706.opl | cut -d' ' -f 10 | sort | uniq -c | sort -nr | sed -e "s#%20%# #g" | head -15
506 changeset_created_by=JOSM/1.5 (12275 en)
242 changeset_created_by=iD 2.2.1
150 changeset_created_by=iD 2.2.2
103 changeset_created_by=Potlatch 2
21 changeset_created_by=JOSM/1.5 (12275 ru)
20 changeset_created_by=JOSM/1.5 (11826 ru)
15 changeset_created_by=JOSM/1.5 (12409 en_AU)
12 changeset_created_by=JOSM/1.5 (11826 en)
9 changeset_created_by=JOSM/1.5 (12275 en_GB)
8 changeset_created_by=JOSM/1.5 (12275 de)
6 changeset_created_by=JOSM/1.5 (12275 fr)
6 changeset_created_by=JOSM/1.5 (12271 hu)
6 changeset_created_by=JOSM/1.5 (11223 Debian es)
5 changeset_created_by=JOSM/1.5 (12275 it)
5 changeset_created_by=JOSM/1.5 (12275 es)
|
I have analyzed the 2017.01.01... - OSM history statistics for creating old-style multipolygons.
As I see some users still using very old OSM editors and creating old-style multi-polygons in 2017 ...
JOSM/1.5 (4878 de)
released: 2012-01-30iD 1.8.5-slide
= https://github.com/strava/iD ( iD editor fork , maybe we need to add to the editor list )OSM Editor statistics ( created_by= ) for old-style multipolygons
Based on OSM History file ( 2017.01.01 -2017.03.20 ) filter for
type=multipolygon
+2017
osmium cat planet.osh.pbf -t relation -f opl | grep " Ttype=multipolygon " | grep " v1 " | egrep " t2017-"
+ JOINcreated_by=
from changesets ..Detailed data with links : https://gist.github.com/ImreSamu/ea6f81856ceaf6e9092469490239fdf1
FREQ:
The text was updated successfully, but these errors were encountered: